lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 7 Jan 2008 18:23:02 +0900 From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com> To: riel@...hat.com Cc: linux-kernel@...r.kernel.org, linux-mm@...ck.org, lee.schermerhorn@...com, Lee Schermerhorn <Lee.Schermerhorn@...com> Subject: Re: [patch 06/19] split LRU lists into anon & file sets On Wed, 02 Jan 2008 17:41:50 -0500 linux-kernel@...r.kernel.org wrote: > static void shrink_active_list(unsigned long nr_pages, struct zone *zone, > - struct scan_control *sc, int priority) > + struct scan_control *sc, int priority, int file) > { > unsigned long pgmoved; > int pgdeactivate = 0; > @@ -1128,64 +1026,65 @@ static void shrink_active_list(unsigned > struct list_head list[NR_LRU_LISTS]; > struct page *page; > struct pagevec pvec; > - int reclaim_mapped = 0; > - enum lru_list l; > + enum lru_list lru; <snip> > + /* > + * For sorting active vs inactive pages, we'll use the 'anon' > + * elements of the local list[] array and sort out the file vs > + * anon pages below. > + */ This is not easy to read.... (this definition affects later patches...) How about adding some new enum (only) for this function ? like LRU_STAY_ACTIVE = 0, LRU_MOVE_INACTIVE = 1, Thanks, -Kame -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists