| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 9 Jan 2008 02:12:33 +0100 From: Andi Kleen <ak@...e.de> To: Jeremy Fitzhardinge <jeremy@...p.org> Cc: Ingo Molnar <mingo@...e.hu>, LKML <linux-kernel@...r.kernel.org>, Andi Kleen <ak@...e.de>, Glauber de Oliveira Costa <glommer@...il.com>, Jan Beulich <jbeulich@...ell.com> Subject: Re: [PATCH 00 of 10] x86: unify asm/pgtable.h On Tue, Jan 08, 2008 at 05:07:08PM -0800, Jeremy Fitzhardinge wrote: > Ingo Molnar wrote: >> * Jeremy Fitzhardinge <jeremy@...p.org> wrote: >> >> >>> In other words, prot and ref_prot can never be equal, so this path is >>> always taken, and the other branch which tests pte_huge() is never run. >>> >>> Andi? Jan? Is this code just buggy, or is there something else going on >>> here? >>> >> >> this code is plain buggy but fixing it triggered driver bugs in the past >> so we've been procrastinating it forever ... >> > > What kind of driver bugs? Do drivers manage to get into the other branch That was just the return value issue that caused drivers to fail through ioremap() iirc. It would error out for unmapped holes and then fail ioremap I don't think it's related. > of the if()? If not, can't we just remove it and avoid this present > problem? That would just hide your problem. -Andi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists