linux-kernel - Re: [PATCH 5/6] Driver for WM97xx touchscreens in streaming mode on PXA2xx systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 14 Jan 2008 14:42:50 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Marc Kleine-Budde <mkl@...gutronix.de>
Cc:	Dmitry Torokhov <dtor@...l.ru>,
	linux-input@...ey.karlin.mff.cuni.cz, linux-kernel@...r.kernel.org,
	Liam Girdwood <liam.girdwood@...fsonmicro.com>,
	Graeme Gregory <gg@...nsource.wolfsonmicro.com>,
	Rodolfo Giometti <giometti@...eenne.com>,
	Russell King <rmk@....linux.org.uk>,
	Ian Molton <spyro@....com>, Vince Sanders <vince@...likki.org>,
	Andrew Zabolotny <zap@...elink.ru>
Subject: Re: [PATCH 5/6] Driver for WM97xx touchscreens in streaming mode
	on PXA2xx systems

On Mon, Jan 14, 2008 at 10:56:06AM +0100, Marc Kleine-Budde wrote:
> reMark Brown wrote:

> > Cc: Marc Kleine-Budde <mkl@...ugtronix.de>
>                                 ^^
> it's mkl@...gutronix.de

Fixed, sorry about that.

> > +			/* use PEN_DOWN GPIO 13 to assert IRQ on GPIO line 2 */
> > +			wm->pen_irq = MAINSTONE_AC97_IRQ;

> I'm missing some kind of abstraction here, what about non mainstone
> boards with the pen irq wired to some other gpio?

The driver really isn't intended to cope with them.  As you say, other
boards may have things wired up differently and therefore require
different configuration of the wm97xx and other bits of the system.  The
expectation is that other systems will have their own driver.

My initial thought is that the most straightforward way of handling this
would be to rename the driver to mainstone-wm97xx or similar to make it
clear that the driver is only intended to handle Mainstone as-is.  Does
that seem reasonable?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/