linux-kernel - Re: [i2c] [PATCH] update module-init-tools to support the i2c subsystem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 14 Jan 2008 20:38:28 +0100
From:	"Kay Sievers" <kay.sievers@...y.org>
To:	"Jean Delvare" <khali@...ux-fr.org>
Cc:	"Geert Uytterhoeven" <Geert.Uytterhoeven@...ycom.com>,
	linuxppc-dev@...abs.org, linux-kernel@...r.kernel.org,
	i2c@...sensors.org
Subject: Re: [i2c] [PATCH] update module-init-tools to support the i2c subsystem

On Jan 14, 2008 6:50 PM, Jean Delvare <khali@...ux-fr.org> wrote:
> On Mon, 14 Jan 2008 18:08:16 +0100 (CET), Geert Uytterhoeven wrote:
> > On Mon, 14 Jan 2008, Jean Delvare wrote:
> > > I thought that the module aliases were generated by
> > > scripts/mod/modpost? As a matter of fact, I did not apply Jon's patch
> >
> > Sorry, you're right. Too early in the morning :-)
> >
> > > to module-init-tools, and "modinfo" shows me module aliases properly
> > > for i2c drivers that call MODULE_DEVICE_TABLE():
> >
> > I've just looked it up again (I had to do a similar thing for Zorro bus
> > support).  Module-init-tools (depmod) also creates the modules.*map files,
> > which are used to map from device IDs to module names. I think these are used
> > by udev to load the appropriate module when a device with a specific device ID
> > pops up in sysfs.
>
> Ah, right. I see it now, there's modules.isapnpmap,
> modules.ieee1394map, modules.pcimap etc. but no modules.i2cmap.
> However, there is modules.alias which contains the i2c aliases for all
> device types (including one ieee1394 and many pci aliases) which seems
> somewhat redundant with the modules.*map files.
>
> > > $ /sbin/modinfo lm90
> > > filename:       /lib/modules/2.6.24-rc7-git4/kernel/drivers/hwmon/lm90.ko
> > > author:         Jean Delvare <khali@...ux-fr.org>
> > > description:    LM90/ADM1032 driver
> > > license:        GPL
> > > vermagic:       2.6.24-rc7-git4 mod_unload
> > > depends:        hwmon
> > > alias:          i2c:Nlm90*
> > > alias:          i2c:Nadm1032*
> > > alias:          i2c:Nlm99*
> > > alias:          i2c:Nlm86*
> > > alias:          i2c:Nmax6657*
> > > alias:          i2c:Nadt7461*
> > > alias:          i2c:Nmax6680*
> > > $
> > >
> > > "modprobe i2c:Nadm1032" loads the lm90 driver as expected.
> >
> > Yes, it's also still not 100% clear to me when `i2c:Nadm1032' is used, and when
> > modules.i2cmap would be used...
>
> I am under the impression that modules.*map are the old way to get
> automatic driver loading and aliases are the new way to do the same.
> But maybe that's just me.

Right, nothing on recent systems is using the map files. This patch
should not be needed.
The plan is to deprecate the creation of these files in depmod.

Thanks,
Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/