linux-kernel - Re: [PATCH 8/12] ide-floppy: merge idefloppy_{input,output}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 15 Jan 2008 08:14:34 +0100
From:	Borislav Petkov <bbpetkov@...oo.de>
To:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
Cc:	linux-kernel@...r.kernel.org, linux-ide@...r.kernel.org
Subject: Re: [PATCH 8/12] ide-floppy: merge idefloppy_{input,output}_buffers

On Mon, Jan 14, 2008 at 10:38:35PM +0100, Bartlomiej Zolnierkiewicz wrote:
> On Sunday 13 January 2008, Borislav Petkov wrote:
> > We merge idefloppy_{input,output}_buffers() into idefloppy_io_buffers() by
> > introducing a 4th arg. called direction. According to its value
> > we atapi_input_bytes() or atapi_output_bytes(). Also, this simplifies the
> > interrupt handler logic a bit. Finally, rename idefloppy_io_buffers() to
> > ide_floppy_io_buffers().
> > 
> > Signed-off-by: Borislav Petkov <bbpetkov@...oo.de>
> 
> This change depends on "ide-floppy: use an xfer_func_t and io_buf_t typedefs
> in order to unify rw" which was not in the "v2.5" series.

Yep, this is correct. Probably i should've mentioned that in the preamble. It
is rather confusing, imho, when sending only a subset of the patches. Rather,
I should've sent the whole series after tagging the ones already applied so
that you have an idea about their ordering. Will note that for the next time.

> I took the patch #16/21 from the previous series and applied it manually
> fixing rejects, please verify that I didn't brake something in the process.

Will do the whole driver testing in the weekend. :)

-- 
Regards/Gruß,
    Boris.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/