linux-kernel - Re: [PATCH] x86: fix unconditional arch/x86/kernel/pcspeaker.c?compiling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 18 Jan 2008 14:57:04 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Matt Mackall <mpm@...enic.com>
Cc:	Michael Opdenacker <michael-lists@...e-electrons.com>,
	linux-kernel@...r.kernel.org, Linux-tiny@...enic.com,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] x86: fix unconditional
	arch/x86/kernel/pcspeaker.c?compiling


* Matt Mackall <mpm@...enic.com> wrote:

> > I can propose a corresponding patch, and I'd suggest to make 
> > CONFIG_PCSPEAKER depend on CONFIG_EMBEDDED.
> 
> No, don't. It's fine the way it is. If INPUT_PCSPKR isn't set, we 
> don't support the speaker, end of story.

yeah.

> Also, bear in mind that there is a fair amount of lower-hanging fruit 
> than this, so bouncing a bunch of patches back and forth to make this 
> perfect is not the best use of people's time.

as long as it's arch/x86 stuff i can pick up patches no problem.

[ Sidenote: "too small" and "too insignificant" is not a patch attribute
  that is in my vocabulary - by definition the best patches are very
  small and very insignificant (they just happen to end up doing
  something cool a 1000 steps later ;-) 99% of our problems come from
  'too large' and 'too intrusive' patches. ]

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/