linux-kernel - Re: [PATCH 19/26] atl1: modernize down/up functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 22 Jan 2008 05:01:23 -0500
From:	Jeff Garzik <jeff@...zik.org>
To:	jacliburn@...lsouth.net
CC:	csnook@...hat.com, linux-kernel@...r.kernel.org,
	atl1-devel@...ts.sourceforge.net
Subject: Re: [PATCH 19/26] atl1: modernize down/up functions

jacliburn@...lsouth.net wrote:
> From: Jay Cliburn <jacliburn@...lsouth.net>
> 
> Update atl1_down() and atl1_up() to conform with the current vendor driver
> version 1.2.40.2.
> 
> Signed-off-by: Jay Cliburn <jacliburn@...lsouth.net>
> ---
>  drivers/net/atlx/atl1.c |   21 ++++++++-------------
>  drivers/net/atlx/atl1.h |    1 -
>  drivers/net/atlx/atlx.c |    2 +-
>  3 files changed, 9 insertions(+), 15 deletions(-)

same comments continue...  these are software changes that need to be 
explained.

"conform with vendor driver" does not excuse failure to document changes 
in init and shutdown sequencing, for example.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/