The selection of many CPU architecture families causes pentium pro memory ordering errata workarounds to be enabled. This causes memory barriers and spinlocks to become much more expensive, just to provide a few hacks for a very rare (nowadays) class of system. Just print a warning if such a machine is detected. Also suggest a new CONFIG option that can be enabled to support such CPUs. This saves nearly 1KB of icache in mm/ alone. Signed-off-by: Nick Piggin --- Index: linux-2.6/arch/x86/Kconfig.cpu =================================================================== --- linux-2.6.orig/arch/x86/Kconfig.cpu +++ linux-2.6/arch/x86/Kconfig.cpu @@ -322,9 +322,21 @@ config X86_XADD default y config X86_PPRO_FENCE - bool + bool "PentiumPro memory ordering errata workaround" depends on M686 || M586MMX || M586TSC || M586 || M486 || M386 || MGEODEGX1 - default y + default n + help + Old PentiumPro multiprocessor systems had errata that could cause + memory operations to violate the x86 ordering standard in rare cases. + Enabling this option will attempt to work around some (but not all) + occurances of these problems, at the cost of much heavier spinlock + and memory barrier operations. + + If you say N here, these systems will be detected and limited to a + single CPU at boot time. + + If unsure, say N here. Even distro kernels should think twice before + enabling this: there are few systems, and an unlikely bug. config X86_F00F_BUG bool Index: linux-2.6/arch/x86/kernel/cpu/intel.c =================================================================== --- linux-2.6.orig/arch/x86/kernel/cpu/intel.c +++ linux-2.6/arch/x86/kernel/cpu/intel.c @@ -108,6 +108,32 @@ static void __cpuinit trap_init_f00f_bug } #endif +/* + * Errata #66, #92, #51 + */ +static void __cpuinit ppro_memory_bug(void) +{ +#ifndef CONFIG_X86_PPRO_FENCE + if (boot_cpu_data.x86_vendor == X86_VENDOR_INTEL && + boot_cpu_data.x86 == 6 && + boot_cpu_data.x86_model == 1) { + if (boot_cpu_data.x86_mask < 8) + printk(KERN_WARNING "WARNING: Pentium Pro with " + "Errata#66, #92, #51 detected. Running this kernel " + "may cause inconsistent results. " + "Enable CONFIG_X86_PPRO_FENCE.\n"); + +#ifdef CONFIG_SMP + else + printk(KERN_WARNING "WARNING: Pentium Pro with " + "Errata#66, #92, #51 detected. Running this kernel " + "in an SMP system may cause inconsistent results. " + "Enable CONFIG_X86_PPRO_FENCE if using SMP system.\n"); +#endif + } +#endif +} + static void __cpuinit init_intel(struct cpuinfo_x86 *c) { unsigned int l2 = 0; @@ -132,6 +158,8 @@ static void __cpuinit init_intel(struct } #endif + ppro_memory_bug(); + select_idle_routine(c); l2 = init_intel_cacheinfo(c); if (c->cpuid_level > 9 ) {