linux-kernel - Re: [PATCH] x86: make nx_enabled conditional on CONFIG_X86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 22 Jan 2008 13:35:15 -0800
From:	Harvey Harrison <harvey.harrison@...il.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	"H. Peter Anvin" <hpa@...or.com>,
	Ian Campbell <ijc@...lion.org.uk>,
	Mika Penttilä <mika.penttila@...umbus.fi>,
	linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>
Subject: Re: [PATCH] x86: make nx_enabled conditional on CONFIG_X86_PAE

On Tue, 2008-01-22 at 22:04 +0100, Ingo Molnar wrote:
> * Harvey Harrison <harvey.harrison@...il.com> wrote:
> 
> > nx_enabled can only be set to non-zero when CONFIG_X86_PAE is set.  
> > The only use not currently inside a CONFIG_X86_PAE block is the 
> > definition, the declaration and a conditional unlikely test in 
> > fault_32.c (is_prefetch).
> > 
> > When !CONFIG_X86_PAE, is_prefetch always returns 0 immediately as 
> > nx_enabled is always 0.
> > 
> > When CONFIG_X86_PAE, the test is preserved, but the test against the 
> > cpu model and stepping is deleted, this may not be correct.
> 
> thanks, applied.

Hmmm, the extern nx_enabled in page_32.h is already within an
ifndef __ASSEMBLY__ block, so I'm not sure how wakeup_32.S could
be using it.  Thoughts?

Harvey

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/