linux-kernel - Re: [PATCH] driver: tcm825x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 25 Jan 2008 22:05:57 +0100 (CET)
From:	Guennadi Liakhovetski <g.liakhovetski@....de>
To:	Cyrill Gorcunov <gorcunov@...il.com>
cc:	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] driver: tcm825x - fix logical typo error

On Fri, 25 Jan 2008, Cyrill Gorcunov wrote:

> This patch does fix potential NULL pointer dereference
> due to logical typo error.
> 
> The issue is pointed out by
> Guennadi Liakhovetski <g.liakhovetski@...gutronix.de>
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov@...il.com>
> ---
> 
> Index: linux-2.6.git/drivers/media/video/tcm825x.c
> ===================================================================
> --- linux-2.6.git.orig/drivers/media/video/tcm825x.c	2008-01-23 19:01:47.000000000 +0300
> +++ linux-2.6.git/drivers/media/video/tcm825x.c	2008-01-25 23:13:15.000000000 +0300
> @@ -851,7 +851,7 @@ static int tcm825x_probe(struct i2c_clie
>  	sensor->platform_data = client->dev.platform_data;
>  
>  	if (sensor->platform_data == NULL
> -	    && !sensor->platform_data->is_okay())
> +	    || !sensor->platform_data->is_okay())
>  		return -ENODEV;
>  
>  	sensor->v4l2_int_device = &tcm825x_int_device;

Now that it missed 2.6.24, you probably want to send it to -stable too. 
Even though the patch is trivial, it might be a good idea to cc: v4l2 
maintainer and / or driver author.

Thanks
Guennadi
---
Guennadi Liakhovetski
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/