linux-kernel - Re: [PATCH 23/23 -v6] Critical latency timings histogram

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 26 Jan 2008 10:11:47 +0100
From:	Pavel Machek <pavel@....cz>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Christoph Hellwig <hch@...radead.org>,
	Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>,
	Gregory Haskins <ghaskins@...ell.com>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Thomas Gleixner <tglx@...utronix.de>,
	Tim Bird <tim.bird@...sony.com>,
	Sam Ravnborg <sam@...nborg.org>,
	"Frank Ch. Eigler" <fche@...hat.com>,
	Jan Kiszka <jan.kiszka@...mens.com>,
	John Stultz <johnstul@...ibm.com>,
	Arjan van de Ven <arjan@...radead.org>,
	Steven Rostedt <srostedt@...hat.com>
Subject: Re: [PATCH 23/23 -v6] Critical latency timings histogram


> +static void *l_start(struct seq_file *m, loff_t *pos)
> +{
> +	loff_t *index_ptr = kmalloc(sizeof(loff_t), GFP_KERNEL);
> +	loff_t index = *pos;
> +	struct hist_data *my_hist = m->private;
> +
> +	if (!index_ptr)
> +		return NULL;
> +
> +	if (index == 0) {
> +		atomic_dec(&my_hist->hist_mode);
> +		seq_printf(m, "#Minimum latency: %lu microseconds.\n"
> +			   "#Average latency: %lu microseconds.\n"
> +			   "#Maximum latency: %lu microseconds.\n"
> +			   "#Total samples: %llu\n"
> +			   "#There are %llu samples greater or equal"
> +			   " than %d microseconds\n"
> +			   "#usecs\t%16s\n"
> +			   , my_hist->min_lat
> +			   , my_hist->avg_lat
> +			   , my_hist->max_lat
> +			   , my_hist->total_samples
> +			   , my_hist->beyond_hist_bound_samples
> +			   , MAX_ENTRY_NUM, "samples");
> +	}

Ok, so you are adding new userland interface; I guess you should also
document it in Documentation/?

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/