linux-kernel - Re: [PATCH] Add iSCSI iBFT support (v0.4.5)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 27 Jan 2008 08:47:36 -0800
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	Konrad Rzeszutek <konrad@...nok.org>, linux-kernel@...r.kernel.org,
	greg@...ah.com, dwm@...yolf.org, darnok@....org, pjones@...hat.com,
	konradr@...hat.com, konradr@...ux.vnet.ibm.com, hpa@...or.com,
	lenb@...nel.org, mike.anderson@...ibm.com, dwm@...tin.ibm.com,
	arjan@...radead.org, michaelc@...wisc.edu,
	Andy Whitcroft <apw@...dowen.org>
Subject: Re: [PATCH] Add iSCSI iBFT support (v0.4.5)

Andrew Morton wrote:

>>  int __initdata user_defined_memmap = 0;

> checkpatch should have told you that this "= 0" shouldn't be there.  But it
> doesn't.


checkpatch checks for static initializers, not non-static ones.
Should that be changed?



>> +	for (pos = (u8 *)hdr; pos < (u8 *)hdr + len; pos ++)
>>
> 
> checkpatch should have caught the " ++" but didn't.  I think it used to. 
> It seems to be going backwards?


-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/