linux-kernel - Re: [PATCH 06/20 -v5] add notrace annotations for NMI routines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 28 Jan 2008 07:15:50 -0500 (EST)
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Jan Kiszka <jan.kiszka@...mens.com>
cc:	Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>,
	LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Christoph Hellwig <hch@...radead.org>,
	Gregory Haskins <ghaskins@...ell.com>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Thomas Gleixner <tglx@...utronix.de>,
	Tim Bird <tim.bird@...sony.com>,
	Sam Ravnborg <sam@...nborg.org>,
	"Frank Ch. Eigler" <fche@...hat.com>,
	John Stultz <johnstul@...ibm.com>,
	Arjan van de Ven <arjan@...radead.org>,
	Steven Rostedt <srostedt@...hat.com>
Subject: Re: [PATCH 06/20 -v5] add notrace annotations for NMI routines


On Mon, 28 Jan 2008, Jan Kiszka wrote:
> Steven Rostedt wrote:
> > On Wed, 23 Jan 2008, Mathieu Desnoyers wrote:
> >
> >> * Steven Rostedt (rostedt@...dmis.org) wrote:
> >>> This annotates NMI functions with notrace. Some tracers may be able
> >>> to live with this, but some cannot. So we turn off NMI tracing.
> >>>
> >>> One solution might be to make a notrace_nmi which would only turn
> >>> off NMI tracing if a trace utility needed it off.
> >>>
> >> Is this still needed with the atomic clocksource read ?
> >>
> >
> > Before you ask again, I've still included this in -v6, simply because I
> > didn't get a chance to test it without this patch. I'll try to remember to
> > do that on Monday.
>
> Only in case you finally have to keep the annotations for the posted
> tracer: Then please make it a Kconfig selectable restriction, because
> there are use cases of the mcount hook where you are interested in NMI
> invocations.

I've thought about adding a notrace_nmi which would do precisely that.
This week I'll take this patch out and turn on a bunch of nmi profiling
and see how it holds up.

Thanks,

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/