linux-kernel - Re: [PATCH 1/2] IRQ_NOPROBE helper functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 31 Jan 2008 01:56:28 -0600
From:	Rob Landley <rob@...dley.net>
To:	Ralf Baechle <ralf@...ux-mips.org>
Cc:	linux-kernel@...r.kernel.org, linux-mips@...r.kernel.org
Subject: Re: [PATCH 1/2] IRQ_NOPROBE helper functions

On Tuesday 29 January 2008 05:20:48 Ralf Baechle wrote:
> Probing non-ISA interrupts using the handle_percpu_irq as their handle_irq
> method may crash the system because handle_percpu_irq does not check
> IRQ_WAITING.  This for example hits the MIPS Qemu configuration.
>
> This patch provides two helper functions set_irq_noprobe and set_irq_probe
> to set rsp. clear the IRQ_NOPROBE flag.  The only current caller is MIPS
> code but this really belongs into generic code.
>
> As an aside, interrupt probing these days has become a mostly obsolete if
> not dangerous art.  I think Linux interrupts should be changed to default
> to non-probing but that's subject of this patch.
>
> Signed-off-by: Ralf Baechle <ralf@...ux-mips.org>

Acked-by: Rob Landley <rob@...dley.net>

To both patches: I can confirm that applying these two fixes together avoids 
the panic for me, although I thought qemu-system-mips used to have a working 
RTC, and I can't seem to find it now.  (Make is unhappy with 1970.  It was 
not a good year for make...)

Thanks,

Rob
-- 
"One of my most productive days was throwing away 1000 lines of code."
  - Ken Thompson.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/