linux-kernel - Re: [git pull] x86 arch updates for v2.6.25

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 31 Jan 2008 18:24:23 +0200
From:	Adrian Bunk <bunk@...sta.de>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Jeremy Fitzhardinge <jeremy@...p.org>
Subject: Re: [git pull] x86 arch updates for v2.6.25

On Thu, Jan 31, 2008 at 05:15:23PM +0100, Ingo Molnar wrote:
> 
> * Adrian Bunk <bunk@...nel.org> wrote:
> 
> > On Thu, Jan 31, 2008 at 05:00:33PM +0100, Ingo Molnar wrote:
> > > 
> > > * Adrian Bunk <bunk@...nel.org> wrote:
> > > 
> > > > You tested x86 but broke more than half a dozen other archtectures, 
> > > > with at least 3 different commits breaking other architectures.
> > > 
> > > Note that all known breakages are fixed in current -git, except for the 
> > > s390 problem that Martin/Nick posted the fix.
> > 
> > What about the breakages caused by commit 
> > a5a19c63f4e55e32dc0bc3d936d7f94793d8b380 (this commit broke the 
> > defconfig compilation on at least avr32, blackfin, sh, sparc and uml)?
> 
> the patch below fixes that.

Is it safe, or why did Jeremy state in the commit
"I removed this include to avoid an include cycle"?

> 	Ingo
> 
> ---
>  include/asm-generic/tlb.h |    1 +
>  1 file changed, 1 insertion(+)
> 
> Index: linux/include/asm-generic/tlb.h
> ===================================================================
> --- linux.orig/include/asm-generic/tlb.h
> +++ linux/include/asm-generic/tlb.h
> @@ -15,6 +15,7 @@
>  
>  #include <linux/swap.h>
>  #include <linux/quicklist.h>
> +#include <asm/pgalloc.h>
>  #include <asm/tlbflush.h>
>  
>  /*

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/