linux-kernel - Re: [PATCH 6 of 7] x86: move pud/pgd functions into common asm/pgalloc.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 02 Feb 2008 03:49:01 -0800
From:	Jeremy Fitzhardinge <jeremy@...p.org>
To:	Ingo Molnar <mingo@...e.hu>
CC:	LKML <linux-kernel@...r.kernel.org>, Andi Kleen <ak@...e.de>,
	Jan Beulich <jbeulich@...ell.com>,
	Eduardo Pereira Habkost <ehabkost@...hat.com>,
	Ian Campbell <ijc@...lion.org.uk>,
	H Peter Anvin <hpa@...or.com>
Subject: Re: [PATCH 6 of 7] x86: move pud/pgd functions into common	asm/pgalloc.h

Ingo Molnar wrote:
> yes but the early hang is very real so either my hardware is stubbornly 
> ignoring that your patch is pure code movement (in which case i'll have 
> to have a word or two with my hardware), or your patch is perhaps wrong 
> somewhere ;-)
>   

I see what it is.  set_pud on 32-bit needs only _PAGE_PRESENT, but for 
64-bit it needs _PAGE_TABLE.

> generally you can protect yourself against full reverts by separating 
> the NOP changes from the non-NOP changes. If a change is small enough i 
> might spot the bug immediately and fix it - otherwise i have to undo 
> your whole series to keep the x86.git ball rolling. I thought we went 
> through this excercise a few times already :-/ ...
>   

This one was supposed to be pure motion, but my eyeball diff failed me.

    J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/