[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sat, 02 Feb 2008 10:51:13 -0500
From: Jeff Garzik <jeff@...zik.org>
To: Ingo Molnar <mingo@...e.hu>
CC: Greg KH <gregkh@...e.de>, Linus Torvalds <torvalds@...l.org>,
Andrew Morton <akpm@...l.org>, linux-kernel@...r.kernel.org,
linux-pci@...ey.karlin.mff.cuni.cz,
pcihpd-discuss@...ts.sourceforge.net,
linux-scsi <linux-scsi@...r.kernel.org>
Subject: Re: [patch] pci: pci_enable_device_bars() fix
Ingo Molnar wrote:
> ===================================================================
> --- linux.orig/drivers/scsi/lpfc/lpfc_init.c
> +++ linux/drivers/scsi/lpfc/lpfc_init.c
> @@ -1894,7 +1894,7 @@ lpfc_pci_probe_one(struct pci_dev *pdev,
> uint16_t iotag;
> int bars = pci_select_bars(pdev, IORESOURCE_MEM);
>
> - if (pci_enable_device_bars(pdev, bars))
> + if (pci_enable_device_io(pdev))
> goto out;
Look at the line right above it... AFAICS you want
pci_enable_device_mem(), if the mask is selecting IORESOURCE_MEM BARs.
Also a CC to linux-scsi and the driver author would be nice, as they are
the ones with hardware and can verify.
This set of changes seemed like 50% guesswork to me, without consulting
the authors :( And unlike many changes, you actually have to know the
hardware [or get clues from surrounding code] to make the change.
Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists