linux-kernel - Re: [PATCH] [wireless/iwlwifi/iwl-4965.c] add parentheses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 2 Feb 2008 22:40:37 +0200
From:	"Tomas Winkler" <tomasw@...il.com>
To:	"Roel Kluin" <12o3l@...cali.nl>
Cc:	yi.zhu@...el.com, reinette.chatre@...el.com,
	linux-wireless@...r.kernel.org,
	ipw3945-devel@...ts.sourceforge.net,
	lkml <linux-kernel@...r.kernel.org>,
	"Ron Rindjunsky" <ron.rindjunsky@...el.com>
Subject: Re: [PATCH] [wireless/iwlwifi/iwl-4965.c] add parentheses

On Feb 2, 2008 9:48 PM, Roel Kluin <12o3l@...cali.nl> wrote:
> '!' has a higher priority than '&': bitanding has no effect.
>
> Signed-off-by: Roel Kluin <12o3l@...cali.nl>
> ---
> diff --git a/drivers/net/wireless/iwlwifi/iwl-4965.c b/drivers/net/wireless/iwlwifi/iwl-4965.c
> index 569347f..2439868 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-4965.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-4965.c
> @@ -4589,7 +4589,7 @@ static u8 iwl4965_is_fat_tx_allowed(struct iwl4965_priv *priv,
>
>         if (sta_ht_inf) {
>                 if ((!sta_ht_inf->ht_supported) ||
> -                  (!sta_ht_inf->cap & IEEE80211_HT_CAP_SUP_WIDTH))
> +                  (!(sta_ht_inf->cap & IEEE80211_HT_CAP_SUP_WIDTH)))
>                         return 0;
>         }
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

ACK
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/