lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 03 Feb 2008 14:20:26 +0800 From: Li Zefan <lizf@...fujitsu.com> To: Jiri Slaby <jirislaby@...il.com> CC: Andrew Morton <akpm@...ux-foundation.org>, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] mxser: fix compile warning building without CONFIG_PCI Jiri Slaby wrote: > On 02/03/2008 03:59 AM, Li Zefan wrote: >> When build without CONFIG_PIC, got the following warnings: >> >> drivers/char/mxser.c: In function 'mxser_init': >> drivers/char/mxser.c:698: warning: unused variable 'devnum' >> drivers/char/mxser.c:698: warning: unused variable 'busnum' >> drivers/char/mxser.c:697: warning: unused variable 'index' >> drivers/char/mxser.c:696: warning: unused variable 'pdev' >> drivers/char/mxser.c:695: warning: unused variable 'n' >> >> Signed-off-by: Li Zefan <lizf@...fujitsu.com> >> --- >> drivers/char/mxser.c | 14 ++++++-------- >> 1 files changed, 6 insertions(+), 8 deletions(-) >> >> diff --git a/drivers/char/mxser.c b/drivers/char/mxser.c >> index fd0abef..b2cc93d 100644 >> --- a/drivers/char/mxser.c >> +++ b/drivers/char/mxser.c >> @@ -692,10 +692,7 @@ static int mxser_get_PCI_conf(int busnum, int >> devnum, int board_type, struct mxs >> >> static int mxser_init(void) >> { >> - int i, m, retval, b, n; >> - struct pci_dev *pdev = NULL; >> - int index; >> - unsigned char busnum, devnum; >> + int i, m, retval, b; >> struct mxser_hwconf hwconf; >> >> mxvar_sdriver = alloc_tty_driver(MXSER_PORTS + 1); >> @@ -834,10 +831,11 @@ static int mxser_init(void) >> >> /* start finding PCI board here */ >> #ifdef CONFIG_PCI >> - n = ARRAY_SIZE(mxser_pcibrds) - 1; >> - index = 0; >> b = 0; >> - while (b < n) { >> + while (b < ARRAY_SIZE(mxser_pcibrds)-1) { >> + unsigned char busnum, devnum; >> + struct pci_dev *pdev; >> + >> pdev = pci_get_device(mxser_pcibrds[b].vendor, >> mxser_pcibrds[b].device, pdev); >> if (pdev == NULL) { > > This version of driver is no longer in -mm. > I didn't know this, so just silently ignore this patch. :) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists