linux-kernel - Re: [PATCH] quota: Turn quotas off when remounting read-only

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 7 Feb 2008 10:36:55 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Jan Kara <jack@...e.cz>
Cc:	linux-kernel@...r.kernel.org, Michael Tokarev <mjt@....msk.ru>,
	stable@...nel.org
Subject: Re: [PATCH] quota: Turn quotas off when remounting read-only

On Thu, 7 Feb 2008 15:37:21 +0100 Jan Kara <jack@...e.cz> wrote:

> Turn off quotas before filesystem is remounted read only. Otherwise quota will
> try to write to read-only filesystem which does no good... We could also just
> refuse to remount ro when quota is enabled but turning quota off is consistent
> with what we do on umount.
> 
> Signed-off-by: Jan Kara <jack@...e.cz>
> ---
> Andrew, this should fix the hang reported... Please apply. Thanks.
> 
> diff --git a/fs/super.c b/fs/super.c
> index ceaf2e3..945c322 100644
> --- a/fs/super.c
> +++ b/fs/super.c
> @@ -603,6 +603,7 @@ int do_remount_sb(struct super_block *sb, int flags, void *data, int force)
>  			mark_files_ro(sb);
>  		else if (!fs_may_remount_ro(sb))
>  			return -EBUSY;
> +		DQUOT_OFF(sb);
>  	}
>  
>  	if (sb->s_op->remount_fs) {

Cool.  And this is applicable to 2.6.23, 2.6.22 and even earlier, isn't it?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/