linux-kernel - Re: [PATCH 1/8] LinuxPPS core support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 8 Feb 2008 20:11:10 +0100
From:	Sam Ravnborg <sam@...nborg.org>
To:	Rodolfo Giometti <giometti@...ux.it>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	David Woodhouse <dwmw2@...radead.org>,
	Dave Jones <davej@...hat.com>
Subject: Re: [PATCH 1/8] LinuxPPS core support.

Hi Rodolfo.

Kconfig bits are trivial and looks OK.

> diff --git a/drivers/pps/Makefile b/drivers/pps/Makefile
> new file mode 100644
> index 0000000..5a9a51b
> --- /dev/null
> +++ b/drivers/pps/Makefile
> @@ -0,0 +1,10 @@
> +#
> +# Makefile for the PPS core.
> +#
> +
> +pps_core-objs			+= pps.o kapi.o sysfs.o
> +obj-$(CONFIG_PPS)		+= pps_core.o

Please use:
pps_core-y        := pps.o kapi.o sysfs.o
obj-$(CONFIG_PPS) := pps_core.o

The change from '+=' to ':=' is purely cosmetic
but I prefer this way to make it explicit that the
variables contain no other values.

> +
> +ifeq ($(CONFIG_PPS_DEBUG),y)
> +EXTRA_CFLAGS += -DDEBUG
> +endif
And this we do so today:
ccflags-$(CONFIG_PPS_DEBUG) := -DDEBUG


I did not look at the code so do not consider it reviewed by
this feedback.

	Sam

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/