linux-kernel - Re: REPOST: [PATCH] Add iSCSI iBFT support (v0.4.7)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 11 Feb 2008 16:56:11 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Greg KH <greg@...ah.com>
CC:	Konrad Rzeszutek <konrad@...nok.org>,
	James Bottomley <James.Bottomley@...senpartnership.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, michaelc@...wisc.edu,
	dwm@...yolf.org, darnok@....org, pjones@...hat.com,
	konradr@...hat.com, konradr@...ux.vnet.ibm.com,
	randy.dunlap@...cle.com, lenb@...nel.org, mike.anderson@...ibm.com,
	dwm@...tin.ibm.com, arjan@...radead.org,
	Andy Whitcroft <apw@...dowen.org>
Subject: Re: REPOST: [PATCH] Add iSCSI iBFT support (v0.4.7)

Greg KH wrote:
> On Mon, Feb 11, 2008 at 06:35:16PM -0500, Konrad Rzeszutek wrote:
>>>> +       if (hdr->id == id_nic) {
>>>> +               pci_dev = pci_get_bus_and_slot((nic->pci_bdf & 0xff00) >>
>>>> 8, +                                              (nic->pci_bdf & 0xff));
>>> pci_get_bus_and_slot fails in the presence of PCI domains, which are
>>> getting to be fairly common even in medium sized servers ... what
>>> happens in that case?
>> The specification did not take that in to account. The Bus/Dev/Func 
>> information is only present there - no domain information.
> 
> That's really broken then.  Common i386 boxes these days have multiple
> PCI domains, it's not all that uncommon at all.
> 
> And almost all big 64 bit boxes have them.

Yes, but common x86 boxes can't *boot* from anything but domain 0 (in 
particular, the domain which the cf8/cfc registers on the boot processor 
activate.)

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/