linux-kernel - Re: [REGRESSION]fan turns at highspeed after suspend2ram

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 12 Feb 2008 23:18:45 +0100
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Mirco Tischler <mt-ml@....de>
Cc:	lkml <linux-kernel@...r.kernel.org>,
	Len Brown <len.brown@...el.com>, Pavel Machek <pavel@...e.cz>,
	Ray Lee <ray-lk@...rabbit.org>
Subject: Re: [REGRESSION]fan turns at highspeed after suspend2ram

On Tuesday, 12 of February 2008, Mirco Tischler wrote:
> 
> Am Dienstag, den 12.02.2008, 01:13 +0100 schrieb Rafael J. Wysocki:
> > Since _GTS and _BFS don't seem to be defined in your box's BIOS, please
> > try to apply the appended patch on top of the revert and see if that breaks
> > things again.
> > 
> > Thanks,
> > Rafael
> > 
> > ---
> >  drivers/acpi/hardware/hwsleep.c |   11 -----------
> >  1 file changed, 11 deletions(-)
> > 
> > Index: linux-2.6/drivers/acpi/hardware/hwsleep.c
> > ===================================================================
> > --- linux-2.6.orig/drivers/acpi/hardware/hwsleep.c
> > +++ linux-2.6/drivers/acpi/hardware/hwsleep.c
> > @@ -199,11 +199,6 @@ acpi_status acpi_enter_sleep_state_prep(
> >  		return_ACPI_STATUS(status);
> >  	}
> >  
> > -	status = acpi_evaluate_object(NULL, METHOD_NAME__GTS, &arg_list, NULL);
> > -	if (ACPI_FAILURE(status) && status != AE_NOT_FOUND) {
> > -		return_ACPI_STATUS(status);
> > -	}
> > -
> >  	/* Setup the argument to _SST */
> >  
> >  	switch (sleep_state) {
> > @@ -554,12 +549,6 @@ acpi_status acpi_leave_sleep_state(u8 sl
> >  		ACPI_EXCEPTION((AE_INFO, status, "During Method _SST"));
> >  	}
> >  
> > -	arg.integer.value = sleep_state;
> > -	status = acpi_evaluate_object(NULL, METHOD_NAME__BFS, &arg_list, NULL);
> > -	if (ACPI_FAILURE(status) && status != AE_NOT_FOUND) {
> > -		ACPI_EXCEPTION((AE_INFO, status, "During Method _BFS"));
> > -	}
> > -
> >  	/*
> >  	 * GPEs must be enabled before _WAK is called as GPEs
> >  	 * might get fired there
> Yes, that's it. This patch breaks things again.

Ouch.  I think I know what the problem is.

On top of this patch, please apply the appended one and retest.

Thanks,
Rafael

---
 drivers/acpi/hardware/hwsleep.c |    1 +
 1 file changed, 1 insertion(+)

Index: linux-2.6/drivers/acpi/hardware/hwsleep.c
===================================================================
--- linux-2.6.orig/drivers/acpi/hardware/hwsleep.c
+++ linux-2.6/drivers/acpi/hardware/hwsleep.c
@@ -566,6 +566,7 @@ acpi_status acpi_leave_sleep_state(u8 sl
 		return_ACPI_STATUS(status);
 	}
 
+	arg.integer.value = sleep_state;
 	status = acpi_evaluate_object(NULL, METHOD_NAME__WAK, &arg_list, NULL);
 	if (ACPI_FAILURE(status) && status != AE_NOT_FOUND) {
 		ACPI_EXCEPTION((AE_INFO, status, "During Method _WAK"));
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/