linux-kernel - Re: [PATCH 02/14] [ISDN] Hisax: eliminate many unnecessary references to CardType[]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 15 Feb 2008 14:37:59 +0100
From:	Sam Ravnborg <sam@...nborg.org>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	linux-kernel@...r.kernel.org, kkeil@...e.de,
	isdn4linux@...tserv.isdn4linux.de
Subject: Re: [PATCH 02/14] [ISDN] Hisax: eliminate many unnecessary references to CardType[]

On Wed, Oct 31, 2007 at 03:42:07AM -0400, Jeff Garzik wrote:
> For the vast majority of CardType[card->typ] uses (but not all!),
> the string is constant for each driver.  Therefore, we may replace
> CardType[card->typ] with the actual string describing the driver, making
> each printk() a bit more simple.
> 
> This also has the nice, intended side effect of greatly reducing
> external references to hisax global CardType[].  This will be of value
> once the ISDN drivers are converted to the ISA/PCI/PNP hotplug APIs.
> 
> Signed-off-by: Jeff Garzik <jgarzik@...hat.com>

Looks good. No comments.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/