linux-kernel - Re: [PATCH] x86: Coding style fixes for arch/x86/kernel/cpu/centaur.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 18 Feb 2008 05:30:19 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Joe Perches <joe@...ches.com>
Cc:	Paolo Ciarrocchi <paolo.ciarrocchi@...il.com>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	"tglx@...utronix.de" <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH] x86: Coding style fixes for
	arch/x86/kernel/cpu/centaur.c


* Joe Perches <joe@...ches.com> wrote:

> > +		if (e820.map[i].type == E820_RESERVED) {
> > +			if (e820.map[i].addr >= 0x100000UL &&
> > +						e820.map[i].addr < clip)
> >  				clip = e820.map[i].addr;
> 
> Doesn't this look better as:
> 
> +			if (e820.map[i].addr >= 0x100000UL &&
> +			    e820.map[i].addr < clip)

yeah, it does - i've changed that.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/