lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 18 Feb 2008 15:39:58 +0900 (JST) From: yamamoto@...inux.co.jp (YAMAMOTO Takashi) To: lizf@...fujitsu.com Cc: akpm@...ux-foundation.org, containers@...ts.linux-foundation.org, linux-kernel@...r.kernel.org, balbir@...ux.vnet.ibm.com Subject: Re: [PATCH 2/3] memcgroup: fix typo in VM_BUG_ON() > No need for VM_BUG_ON(pc), since 'pc' is the list entry. This should > be VM_BUG_ON(page). > > Signed-off-by: Li Zefan <lizf@...fujitsu.com> > Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com> > --- > mm/memcontrol.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 6bded84..c2959ee 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -534,7 +534,7 @@ unsigned long mem_cgroup_isolate_pages(unsigned long nr_to_scan, > if (scan >= nr_to_scan) > break; > page = pc->page; > - VM_BUG_ON(!pc); > + VM_BUG_ON(!page); can't page be NULL here if mem_cgroup_uncharge clears pc->page behind us? ie. bug. YAMAMOTO Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists