linux-kernel - Re: [PATCH 5/7] cgroup: fix subsys bitops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 19 Feb 2008 18:57:54 -0800
From:	"Paul Menage" <menage@...gle.com>
To:	"Li Zefan" <lizf@...fujitsu.com>
Cc:	"Andrew Morton" <akpm@...ux-foundation.org>,
	"KAMEZAWA Hiroyuki" <kamezawa.hiroyu@...fujitsu.com>,
	LKML <linux-kernel@...r.kernel.org>,
	containers@...ts.linux-foundation.org
Subject: Re: [PATCH 5/7] cgroup: fix subsys bitops

On Feb 17, 2008 9:49 PM, Li Zefan <lizf@...fujitsu.com> wrote:
> Cgroup uses unsigned long for subsys bitops, not unsigned long long.
>
> Signed-off-by: Li Zefan <lizf@...fujitsu.com>

Acked-by: Paul Menage <menage@...gle.com>

> ---
>  kernel/cgroup.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/cgroup.c b/kernel/cgroup.c
> index aa76bbd..e8c8e58 100644
> --- a/kernel/cgroup.c
> +++ b/kernel/cgroup.c
> @@ -320,7 +320,7 @@ static struct css_set *find_existing_css_set(
>         /* Built the set of subsystem state objects that we want to
>          * see in the new css_set */
>         for (i = 0; i < CGROUP_SUBSYS_COUNT; i++) {
> -               if (root->subsys_bits & (1ull << i)) {
> +               if (root->subsys_bits & (1UL << i)) {
>                         /* Subsystem is in this hierarchy. So we want
>                          * the subsystem state from the new
>                          * cgroup */
> @@ -696,7 +696,7 @@ static int rebind_subsystems(struct cgroupfs_root *root,
>         added_bits = final_bits & ~root->actual_subsys_bits;
>         /* Check that any added subsystems are currently free */
>         for (i = 0; i < CGROUP_SUBSYS_COUNT; i++) {
> -               unsigned long long bit = 1ull << i;
> +               unsigned long bit = 1UL << i;
>                 struct cgroup_subsys *ss = subsys[i];
>                 if (!(bit & added_bits))
>                         continue;
> --
> 1.5.4.rc3
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/