linux-kernel - Re: [PATCH] X86: remove WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 21 Feb 2008 12:54:52 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Joerg Roedel <joerg.roedel@....com>
Cc:	tglx@...utronix.de, mingo@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] X86: remove WARN_ON if MTRRs are all blank


* Joerg Roedel <joerg.roedel@....com> wrote:

>  	if (!highest_pfn) {
>  		printk(KERN_WARNING "WARNING: strange, CPU MTRRs all blank?\n");
> -		WARN_ON(1);
>  		return 0;
>  	}

instead of obscuring a possibly useful warning, please instead detect 
that it's a KVM guest and skip both the warning and the backtrace in 
that case.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/