linux-kernel - RE: [git patches] net driver updates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 20 Feb 2008 21:57:08 -0800
From:	"Divy Le Ray" <divy@...lsio.com>
To:	"David Miller" <davem@...emloft.net>, <krkumar2@...ibm.com>
Cc:	<jeff@...zik.org>, <linux-kernel@...r.kernel.org>,
	<netdev@...r.kernel.org>
Subject: RE: [git patches] net driver updates



> -----Original Message-----
> From: David Miller [mailto:davem@...emloft.net]
> Sent: Wednesday, February 20, 2008 9:47 PM
> To: krkumar2@...ibm.com
> Cc: Divy Le Ray; jeff@...zik.org; linux-kernel@...r.kernel.org;
> netdev@...r.kernel.org
> Subject: Re: [git patches] net driver updates
> 
> From: Krishna Kumar2 <krkumar2@...ibm.com>
> Date: Thu, 21 Feb 2008 09:13:49 +0530
> 
> > Hi Divy,
> >
> > > > Explain why, so I can include it in the changelog please...
> > >
> > > Hi Jeff,
> > >
> > > The first part of the patch removes the !netif_queue_stopped(dev).
> > > It opens the race discussed a while ago between Stephen hemminger
> and
> > > David Miller:
> > > http://marc.info/?l=linux-netdev&m=113383224512427&w=2
> >
> > I feel this race cannot happen anymore. I think the fix for that
race
> was
> > to introduce the
> > __LINK_STATE_QDISC_RUNNING bit thus eliminating any races between
> CPU's. If
> > one
> > CPU has called xmit, the other CPU will enqueue skbs (by holding the
> > queue_lock) and
> > exit from qdisc_run since it finds the bit set already.
> 
> And the race is talking about LLTX, which S2IO doesn't use as
> far as I can tell.

Dave,

The driver is cxgb3 here, it uses LLTX.

Cheers,
Divy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/