linux-kernel - Re: [PATCH] x86: X86_HT always enable on X86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 27 Feb 2008 13:30:59 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Adrian Bunk <bunk@...nel.org>
CC:	Hiroshi Shimamoto <h-shimamoto@...jp.nec.com>,
	Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>,
	Sam Ravnborg <sam@...nborg.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: X86_HT always enable on X86_64 SMP

Adrian Bunk wrote:
> On Wed, Feb 27, 2008 at 01:16:30PM -0800, Hiroshi Shimamoto wrote:
>> From: Hiroshi Shimamoto <h-shimamoto@...jp.nec.com>
>>
>> X86_HT is used for hyperthreading or multicore on 32-bit.
>> The X86_HT on 64-bit is different from 32-bit, it means hyperthreading only.
>> And X86_HT is not used on 64-bit except from cpu/initel_cacheinfo.c.
>>
>> Unify X86_HT for hyperthreading or multicore.
>> Turn X86_HT on when X86_64 and SMP are enabled.
> 
> Please fix it properly instead - fiddling around with it the way you do
> only asks for trouble in the future.
> 
> What we need are two different variables for:
> - hyperthreading and
> - multicore
> 

He does, and calls them SCHED_SMT and SCHED_MC respectively.

It's not particularly clear to me what X86_HT is meant to be used for 
anymore at all.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/