linux-kernel - Re: (regression) kernel/timeconst.h bugs with HZ=128

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 26 Feb 2008 16:09:58 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	David Brownell <david-b@...bell.net>
Cc:	linux-kernel@...r.kernel.org, "H. Peter Anvin" <hpa@...or.com>,
	linux-arm-kernel@...ts.arm.linux.org.uk
Subject: Re: (regression) kernel/timeconst.h bugs with HZ=128

On Tue, 26 Feb 2008 10:32:24 -0800 David Brownell <david-b@...bell.net> wrote:

> I see these warnings on 32 bit ARM systems:
> 
>   CC      kernel/time.o
> kernel/time.c: In function 'msecs_to_jiffies':
> kernel/time.c:472: warning: integer constant is too large for 'long' type
> kernel/time.c: In function 'usecs_to_jiffies':
> kernel/time.c:487: warning: integer constant is too large for 'long' type
> 
> Line 472: 
> 	return ((u64)MSEC_TO_HZ_MUL32 * m + MSEC_TO_HZ_ADJ32)
> line 487:
> 	return ((u64)USEC_TO_HZ_MUL32 * u + USEC_TO_HZ_ADJ32)
> 
> The problem seems to be that these constants from kernel/timeconst.h
> have too many digits:
> 
> #define ONLY_THIRTYTWO_BITS	0x01234567
> 
> #define MSEC_TO_HZ_ADJ32        0x3f7ced916
> #define USEC_TO_HZ_ADJ32        0xfffbce4217d
> 
> Those *_ADJ32 constants should have "ULL" suffixes, yes?
> Adding that by hand resolves the problem, but only until
> the next time that header file gets regenerated.
> 
> Someone with observable Perl-fu should fix this ...
> 

(cc's added)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/