linux-kernel - Unmatched semaphore usage in fs/super.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 2 Mar 2008 15:10:35 +0800
From:	"Peter Teoh" <htmldeveloper@...il.com>
To:	LKML <linux-kernel@...r.kernel.org>
Subject: Unmatched semaphore usage in fs/super.c

Please pardon me if wrong.   In fs/super.c, I saw a down_read()
without a matching (when sb->s_root is non-zero) up_read() as shown
below:

/**
 *      get_super - get the superblock of a device
 *      @bdev: device to get the superblock for
 *
 *      Scans the superblock list and finds the superblock of the file system
 *      mounted on the device given. %NULL is returned if no match is found.
 */

struct super_block * get_super(struct block_device *bdev)
{
       struct super_block *sb;

       if (!bdev)
               return NULL;

       spin_lock(&sb_lock);
rescan:
       list_for_each_entry(sb, &super_blocks, s_list) {
               if (sb->s_bdev == bdev) {
                       sb->s_count++;
                       spin_unlock(&sb_lock);
                       down_read(&sb->s_umount);
                       if (sb->s_root)
                               return sb;
                       up_read(&sb->s_umount);
                       /* restart only when sb is no longer on the list */
                       spin_lock(&sb_lock);
                       if (__put_super_and_need_restart(sb))
                               goto rescan;
               }
       }
       spin_unlock(&sb_lock);
       return NULL;
}

Neither did the get_super() caller remember and correct the semaphore
either.   Is this a problem?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/