linux-kernel - Re: [PATCH] ACPI: Unneccessary to scan the PCI bus already scanned.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 3 Mar 2008 02:01:16 -0800
From:	"Yinghai Lu" <yhlu.kernel@...il.com>
To:	"Ingo Molnar" <mingo@...e.hu>, "Greg KH" <gregkh@...e.de>,
	"Muli Ben-Yehuda" <muli@...ibm.com>
Cc:	"Zhao Yakui" <yakui.zhao@...el.com>, lenb@...nel.org,
	linux-acpi@...r.kernel.org,
	"Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ACPI: Unneccessary to scan the PCI bus already scanned.

On Mon, Mar 3, 2008 at 12:30 AM, Yinghai Lu <yhlu.kernel@...il.com> wrote:
> that regression is caused by:
>
>  commit 08f1c192c3c32797068bfe97738babb3295bbf42
>  Author: Muli Ben-Yehuda <muli@...ibm.com>
>  Date:   Sun Jul 22 00:23:39 2007 +0300
>
>     x86-64: introduce struct pci_sysdata to facilitate sharing of ->sysdata
>
>     This patch introduces struct pci_sysdata to x86 and x86-64, and
>     converts the existing two users (NUMA, Calgary) to use it.
>
>     This lays the groundwork for having other users of sysdata, such as
>     the PCI domains work.
>
>     The Calgary bits are tested, the NUMA bits just look ok.
>
>     Signed-off-by: Jeff Garzik <jeff@...zik.org>
>     Signed-off-by: Muli Ben-Yehuda <muli@...ibm.com>
>     Signed-off-by: Linus Torvalds <torvalds@...ux-foundation.org>
>
>  that replace pcibios_scan_root by pci_scan_bus_parented...
>  -       bus = pcibios_scan_root(busnum);
>  +       sd->node = -1;
>  +
>  +       pxm = acpi_get_pxm(device->handle);
>  +#ifdef CONFIG_ACPI_NUMA
>  +       if (pxm >= 0)
>
> +               sd->node = pxm_to_node(pxm);
>  +#endif
>  +
>  +       bus = pci_scan_bus_parented(NULL, busnum, &pci_root_ops, sd);
>
>  and in pcibios_scan_root we have
>
>         struct pci_bus *bus = NULL;
>         struct pci_sysdata *sd;
>
>         dmi_check_system(pciprobe_dmi_table);
>
>         while ((bus = pci_find_next_bus(bus)) != NULL) {
>                 if (bus->number == busnum) {
>                         /* Already scanned */
>                         return bus;
>                 }
>         }
>

Ingo,

Yakui's patch should be applied for 2.6.25, and 2.6.23 stable, and
2.6.24 stable.

also please use attached patch to replace the one patch in x86.git#
testing. old one can not be applied after Yakui's patch.

YH

View attachment "get_mp_bus_early_v2.patch" of type "text/x-patch" (12386 bytes)