linux-kernel - Re: [Cbe-oss-dev] [PATCH] ps3disk: Remove a superfluous cast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 3 Mar 2008 05:19:16 +0100
From:	Christoph Hellwig <hch@....de>
To:	Geert Uytterhoeven <Geert.Uytterhoeven@...ycom.com>
Cc:	Jens Axboe <axboe@...nel.dk>,
	Linux Kernel Development <linux-kernel@...r.kernel.org>,
	Cell Broadband Engine OSS Development 
	<cbe-oss-dev@...abs.org>
Subject: Re: [Cbe-oss-dev] [PATCH] ps3disk: Remove a superfluous cast

On Fri, Feb 15, 2008 at 02:42:03PM +0100, Geert Uytterhoeven wrote:
> ps3disk: Remove a superfluous cast
> 
> As ps3disk is a ppc64-only driver, sector_t equals to unsigned long, and the
> cast is not needed.
> 
> Reuse in another (possibly 32-bit) driver is protected by the safety net called
> `compiler warning' (with the cast, it may silently truncate to 32-bit).
> If sector_t ever changes, we will get a compiler warning as well (with the
> cast, we won't).

Yes, this sounds fine to me.

ACK.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/