linux-kernel - Re: bisected boot regression post 2.6.25-rc3.. please revert

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 03 Mar 2008 14:55:30 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Segher Boessenkool <segher@...nel.crashing.org>
CC:	hans.rosenfeld@....com, torvalds@...ux-foundation.org,
	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>,
	Arjan van de Ven <arjan@...ux.intel.com>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: bisected boot regression post 2.6.25-rc3.. please revert

Segher Boessenkool wrote:
>>> so (on 32-bit) ~_PAGE_PSE is ~0x80L is 0xffffff7f, which when cast to
>>> 64-bit is 0x00000000ffffff7f,
>>
>> Actually, it is signed, so this isn't true.  Comments about unsafeness
>> still apply.
> 
> It turns out that PAGE_SIZE is unsigned.  So this gives us for
> 
>     (~PAGE_MASK & ~_PAGE_USER & ~_PAGE_PSE & ~_PAGE_NX)
> 
> the types UL, L, L, ULL resp.
> 
> The associativity of & is left-to-right, so this in turn becomes
> 
>     UL, L, ULL
> 
>     UL, ULL
> 
>     ULL
> 
> and that cast from UL to ULL doesn't sign-extend.
> 

All the masks either need to be the proper size or signed.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/