linux-kernel - Re: [linux-pm] [PATCH RFC] introduce pm_call() macro to get rid of most #ifdef CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 4 Mar 2008 00:16:43 +0100
From:	Pavel Machek <pavel@....cz>
To:	David Brownell <david-b@...bell.net>
Cc:	linux-pm@...ts.linux-foundation.org,
	Anton Vorontsov <cbouatmailru@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [linux-pm] [PATCH RFC] introduce pm_call() macro to get rid of
	most #ifdef CONFIG_PM

Hi!


> > > +/* avoid `defined but not used' warning */
> > > +#define pm_call(x) ((x) - 1 ? NULL : NULL)
> > > +#endif /* CONFIG_PM */
> > > +
> > 
> > This is evil.
> 
> Ugly, yes.  It might merit some casts too.
> 
> 
> > Maybe your gcc is smart enough to optimize this away, 
> > but I'm not sure mine is.
> 
> It'll be a constant expression; it certainly ought to be.

Well, we have just fooler compiler to think that x is used, and now we
want it to realize that x is unused and compile it out?

Maybe it is smart enough, but...
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/