linux-kernel - Re: [patch 16/20] non-reclaimable mlocked pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 05 Mar 2008 09:28:21 +0900
From:	minchan Kim <minchan.kim@...il.com>
To:	Rik van Riel <riel@...hat.com>
CC:	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Lee Schermerhorn <Lee.Schermerhorn@...com>
Subject: Re: [patch 16/20] non-reclaimable mlocked pages

Hi, Rik.

There is a some trivial mistake.
It can cause compile error.

 >@@ -665,7 +677,12 @@ static int prep_new_page(struct page *pa
 >
 > 	page->flags &= ~(1 << PG_uptodate | 1 << PG_error | 1 << PG_readahead |
 > 			1 << PG_referenced | 1 << PG_arch_1 |
 >-			1 << PG_owner_priv_1 | 1 << PG_mappedtodisk);
 >+			1 << PG_owner_priv_1 | 1 << PG_mappedtodisk |
 >+#ifdef CONFIG_NORECLAIM_MLOCK
 >+//TODO take care of it here, for now.
 >+			1 << PG_mlocked
 >+#endif
 >+			);
 > 	set_page_private(page, 0);
 > 	set_page_refcounted(page);

we need to fix it.

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 78c3f94..f6d535f 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -677,10 +677,10 @@ static int prep_new_page(struct page *page, int 
order, gfp_t gfp_flags)

   page->flags &= ~(1 << PG_uptodate | 1 << PG_error | 1 << PG_readahead |
       1 << PG_referenced | 1 << PG_arch_1 |
-     1 << PG_owner_priv_1 | 1 << PG_mappedtodisk |
+     1 << PG_owner_priv_1 | 1 << PG_mappedtodisk
  #ifdef CONFIG_NORECLAIM_MLOCK
  //TODO take care of it here, for now.
-     1 << PG_mlocked
+     | 1 << PG_mlocked
  #endif
       );
   set_page_private(page, 0);

Thanks,
barrios.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/