| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 6 Mar 2008 01:59:11 +0000 From: "Duane Griffin" <duaneg@...da.com> To: linux-ext4@...r.kernel.org Cc: linux-kernel@...r.kernel.org, Theodore Tso <tytso@....edu>, sct@...hat.com, akpm@...ux-foundation.org, adilger@...sterfs.com, Duane Griffin <duaneg@...da.com> Subject: [RFC, PATCH 3/6] jbd: only create debugfs entries if cache initialisation is successful JBD debugfs entries should only be created if cache initialisation is successful. At the moment they are being created unconditionally which will leave them dangling if cache (and hence module) initialisation fails. Signed-off-by: Duane Griffin <duaneg@...da.com> --- This patch is an independent bug fix and following patches in this series do not depend on it. fs/jbd/journal.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/jbd/journal.c b/fs/jbd/journal.c index 3f334a3..a868277 100644 --- a/fs/jbd/journal.c +++ b/fs/jbd/journal.c @@ -1942,9 +1942,10 @@ static int __init journal_init(void) BUILD_BUG_ON(sizeof(struct journal_superblock_s) != 1024); ret = journal_init_caches(); - if (ret != 0) + if (ret == 0) + jbd_create_debugfs_entry(); + else journal_destroy_caches(); - jbd_create_debugfs_entry(); return ret; } -- 1.5.3.7 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists