lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 05 Mar 2008 17:24:10 -0700 From: ebiederm@...ssion.com (Eric W. Biederman) To: Pavel Emelyanov <xemul@...nvz.org> Cc: Andrew Morton <akpm@...ux-foundation.org>, David Miller <davem@...emloft.net>, Linux Netdev List <netdev@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Alexey Dobriyan <adobriyan@...nvz.org> Subject: Re: [PATCH] Make /proc/net a symlink on /proc/self/net Pavel Emelyanov <xemul@...nvz.org> writes: > Current /proc/net is done with so called "shadows", but current > implementation is broken and has little chances to get fixed. > > The problem is that dentries subtree of /proc/net directory has > fancy revalidation rules to make processes living in different > net namespaces see different entries in /proc/net subtree, but > currently, tasks see in the /proc/net subdir the contents of any > other namespace, depending on who opened the file first. > > The proposed fix is to turn /proc/net into a symlink, which points > to /proc/self/net, which in turn shows what previously was in > /proc/net - the network-related info, from the net namespace the > appropriate task lives in. > > # ls -l /proc/net > lrwxrwxrwx 1 root root 8 Mar 5 15:17 /proc/net -> self/net > > In other words - this behaves like /proc/mounts, but unlike > "mounts", "net" is not a file, but a directory. Overall this looks good, thanks. As a follow on patch this should be moved from /proc/<pid>/net into /proc/<pid>/task/<tid>/net. We don't have anything that currently forces network namespaces to be the same between different tasks of the same task group (I just looked), nor do we have a technical reason to require that. So we should fix our infrastructure to include the companion of /proc/self, a /proc/current (which points at the current task) after which it should be about a two line change to move this from the tgid to the task directory. Eric -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists