linux-kernel - Re: [PATCH 2.6.25-rc3-mm1] IPC: fix a kernel-doc warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 07 Mar 2008 13:01:41 -0800
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Pierre Peiffer <peifferp@...il.com>
CC:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2.6.25-rc3-mm1] IPC: fix a kernel-doc warning

Pierre Peiffer wrote:
> Hi,
> 
> This patch fixes this warning produced by kernel-doc (thanks Randy Dunlap):
> 
> Warning(linux-2.6.25-rc3-mm1//ipc/util.c:845):
> No description found for parameter 'extrat_perm'
> 
> It is due to an inconsistency in a variable name between the C-code and
> the associated comment.
> 
> Signed-off-by: Pierre Peiffer <peifferp@...il.com>

Thanks, looks good.
Acked-by: Randy Dunlap <randy.dunlap@...cle.com>

> ---
>  ipc/util.c |    4 ++--
>  ipc/util.h |    2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> Index: b/ipc/util.c
> ===================================================================
> --- a/ipc/util.c
> +++ b/ipc/util.c
> @@ -841,7 +841,7 @@
>   *    or an err-code without any lock held otherwise.
>   */
>  struct kern_ipc_perm *ipcctl_pre_down(struct ipc_ids *ids, int id, int cmd,
> -				      struct ipc64_perm *perm, int extrat_perm)
> +				      struct ipc64_perm *perm, int extra_perm)
>  {
>  	struct kern_ipc_perm *ipcp;
>  	int err;
> @@ -858,7 +858,7 @@
>  		goto out_unlock;
> 
>  	if (cmd == IPC_SET) {
> -		err = audit_ipc_set_perm(extrat_perm, perm->uid,
> +		err = audit_ipc_set_perm(extra_perm, perm->uid,
>  					 perm->gid, perm->mode);
>  		if (err)
>  			goto out_unlock;
> Index: b/ipc/util.h
> ===================================================================
> --- a/ipc/util.h
> +++ b/ipc/util.h
> @@ -114,7 +114,7 @@
>  void ipc64_perm_to_ipc_perm(struct ipc64_perm *in, struct ipc_perm *out);
>  void ipc_update_perm(struct ipc64_perm *in, struct kern_ipc_perm *out);
>  struct kern_ipc_perm *ipcctl_pre_down(struct ipc_ids *ids, int id, int cmd,
> -				      struct ipc64_perm *perm, int extrat_perm);
> +				      struct ipc64_perm *perm, int extra_perm);
> 
>  #if defined(__ia64__) || defined(__x86_64__) || defined(__hppa__) ||
> defined(__XTENSA__)
>    /* On IA-64, we always use the "64-bit version" of the IPC structures.  */
> 


-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/