linux-kernel - Re: ADT746X: logical-bitwise & confusion in set_max_duty_at

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 10 Mar 2008 19:06:53 +1100
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Colin Leroy <colin@...ino.net>
Cc:	Roel Kluin <12o3l@...cali.nl>, lkml <linux-kernel@...r.kernel.org>
Subject: Re: ADT746X: logical-bitwise & confusion in set_max_duty_at_crit()


On Mon, 2008-03-10 at 08:46 +0100, Colin Leroy wrote:
> On Mon, 10 Mar 2008 01:04:33 +0100, Roel Kluin wrote:
> 
> Hi,
> 
> > logical-bitwise & confusion
> 
> Looks good to me, but I'm not really maintaining that anymore :-)
> I'm not sure who does, Cc:ing Benjamin as he'll probably know.

Nobody is U suspect...

Send it to the list linuxppc-dev@...abs.org, it should be picked up
anyway.

Ben.

> > Signed-off-by: Roel Kluin <12o3l@...cali.nl>
> > ---
> > diff --git a/drivers/hwmon/adt7473.c b/drivers/hwmon/adt7473.c
> > index 9587869..8ea7da2 100644
> > --- a/drivers/hwmon/adt7473.c
> > +++ b/drivers/hwmon/adt7473.c
> > @@ -570,7 +570,7 @@ static ssize_t set_max_duty_at_crit(struct device
> > *dev, struct i2c_client *client = to_i2c_client(dev);
> >  	struct adt7473_data *data = i2c_get_clientdata(client);
> >  	int temp = simple_strtol(buf, NULL, 10);
> > -	temp = temp && 0xFF;
> > +	temp &= 0xFF;
> >  
> >  	mutex_lock(&data->lock);
> >  	data->max_duty_at_overheat = temp;
> > 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/