lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Tue, 11 Mar 2008 21:36:06 +0300
From:	Oleg Nesterov <oleg@...sign.ru>
To:	Roland McGrath <roland@...hat.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] signals: document CLD_CONTINUED notification mechanics

(surprisingly, this is rather important issue for me ;)

On 03/10, Roland McGrath wrote:
>
> >  		if (why) {
> > +			/* The first thread which returns from finish_stop()
> 
> Canonical style is:
> 
> 			/*
> 			 * The first thread that returns from finish_stop()

Yes, I know. But the latter needs an extra line! Don't get me wrong, I am
not worrying about the result of `wc ...`, and I often add the blank lines
to improve the readability. But since the comment block itself adds the
"space", why should we lessen the number of the code lines visible to the
reader?

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ