linux-kernel - Re: [PATCH rc5-mm1 2/3] just return do_try_to_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 12 Mar 2008 13:58:46 +0000
From:	Mel Gorman <mel@....ul.ie>
To:	Hugh Dickins <hugh@...itas.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Balbir Singh <balbir@...ux.vnet.ibm.com>,
	Pavel Emelyanov <xemul@...nvz.org>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH rc5-mm1 2/3] just return do_try_to_free_pages

On (11/03/08 21:14), Hugh Dickins didst pronounce:
> do_try_to_free_pages returns 0 or 1, and try_to_free_mem_cgroup_pages
> returns 0 or 1 accordingly: let's accomplish that in the obvious way.
> 
> Signed-off-by: Hugh Dickins <hugh@...itas.com>

Looks right, it means it's behaviour closer matches try_to_free_pages()
which is a bonus.

Acked-by: Mel Gorman <mel@....ul.ie>

> ---
> 
>  mm/vmscan.c |    4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> --- 2.6.25-rc5-mm1+/mm/vmscan.c	2008-03-11 20:09:05.000000000 +0000
> +++ linux/mm/vmscan.c	2008-03-11 20:15:47.000000000 +0000
> @@ -1457,9 +1457,7 @@ unsigned long try_to_free_mem_cgroup_pag
>  	sc.gfp_mask = (gfp_mask & GFP_RECLAIM_MASK) |
>  			(GFP_HIGHUSER_MOVABLE & ~GFP_RECLAIM_MASK);
>  	zonelist = NODE_DATA(numa_node_id())->node_zonelists;
> -	if (do_try_to_free_pages(zonelist, sc.gfp_mask, &sc))
> -		return 1;
> -	return 0;
> +	return do_try_to_free_pages(zonelist, sc.gfp_mask, &sc);
>  }
>  #endif
>  
> 

-- 
Mel Gorman
Part-time Phd Student                          Linux Technology Center
University of Limerick                         IBM Dublin Software Lab
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/