linux-kernel - Re: 2.6.25-rc5-mm1 - x86_64 boot problem with git-sched.patch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 13 Mar 2008 09:40:28 -0800
From:	Badari Pulavarty <pbadari@...ibm.com>
To:	Andrew Morton <akpm@...ux-foundation.org>, guichaz@...oo.fr
Cc:	a.p.zijlstra@...llo.nl, mingo@...e.hu, vatsa@...ux.vnet.ibm.com,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: 2.6.25-rc5-mm1 - x86_64 boot problem with git-sched.patch

On Thu, 2008-03-13 at 09:09 -0800, Badari Pulavarty wrote:
> On Wed, 2008-03-12 at 11:15 -0700, Andrew Morton wrote:
> > On Wed, 12 Mar 2008 10:10:50 -0800 Badari Pulavarty <pbadari@...il.com> wrote:
> > 
> > > On Tue, 2008-03-11 at 01:14 -0700, Andrew Morton wrote:
> > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.25-rc5/2.6.25-rc5-mm1/
> > > > 
> > > 
> > > I am having trouble booting rc5-mm1 on my x86_64. (ppc64 boots & works
> > > fine). Seems to be a networking issues (hangs on boot). Here are the 
> > > messages on the console (not really useful to me).
> 
> 
> Hi Andrew,
> 
> Finally narrowed down the problem to git-sched.patch in rc5-mm1.
> I am going to try which individual patch in that git caused my
> amd64 boot hang.
> 

Further narrowed it down to following patch in git-sched.patch.
When I back out this patch from rc5-mm1, my amd64 box boots fine.

commit 60befbc1c0b6d141c9c26e61ddd303aedd1e7396
Author: Guillaume Chazarain <guichaz@...oo.fr>
Date:   Mon Mar 10 08:16:41 2008 +0100

    sched: make sure jiffies is up to date before calling
__update_rq_clock()

    Now that __update_rq_clock() uses jiffies to detect clock overflows,
    make sure jiffies are up to date before touch_softlockup_watchdog().

    Removed a touch_softlockup_watchdog() call becoming redundant with
the
    added tick_nohz_update_jiffies().

    Signed-off-by: Guillaume Chazarain <guichaz@...oo.fr>
    Signed-off-by: Ingo Molnar <mingo@...e.hu>

diff --git a/kernel/sched.c b/kernel/sched.c
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -66,6 +66,7 @@
 #include <linux/unistd.h>
 #include <linux/pagemap.h>
 #include <linux/hrtimer.h>
+#include <linux/tick.h>
 
 #include <asm/tlb.h>
 #include <asm/irq_regs.h>
@@ -913,7 +914,7 @@ void sched_clock_idle_wakeup_event(u64 delta_ns)
        rq->prev_clock_raw = now;
        rq->clock += delta_ns;
        spin_unlock(&rq->lock);
-       touch_softlockup_watchdog();
+       tick_nohz_update_jiffies();
 }
 EXPORT_SYMBOL_GPL(sched_clock_idle_wakeup_event);


Thanks,
Badari

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/