linux-kernel - Re: Linux 2.6.25-rc4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 16 Mar 2008 11:13:42 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
cc:	Anders Eriksson <aeriksson@...tmail.fm>,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	Jens Axboe <jens.axboe@...cle.com>,
	Ingo Molnar <mingo@...e.hu>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: Linux 2.6.25-rc4



On Sun, 16 Mar 2008, Bartlomiej Zolnierkiewicz wrote:
> 
> We don't do error handling for special commands (REQ_TYPE_ATA_*) at all,
> ide_error() just dumps device's status/error register(s) and finishes early:

Well that sounds bogus too, for all the same reasons already outlined. The 
DRQ flag needs to be cleared up on error!

> Moreover the problem was initially narrowed down to commit
> 852738f39258deafb3d89c187cb1a4050820d555 which is two commits _before_
> the one that we are currently discussing.

.. and that initial narrowing down is now in doubt, with the new one 
pointing to that DRQ-logic-changing commit!

IOW, Anders re-did things more carefully, and came to a new result. Why 
are you apparenrly ignoring that fact?

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/