linux-kernel - Re: Fix permissions of /proc/net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 20 Mar 2008 10:56:31 +0300
From:	Pavel Emelyanov <xemul@...nvz.org>
To:	Andre Noll <maan@...temlinux.org>,
	"David S. Miller" <davem@...emloft.net>
CC:	"Eric W. Biederman" <ebiederm@...ssion.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Benjamin Thery <benjamin.thery@...l.net>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: Fix permissions of /proc/net

Andre Noll wrote:
> commit f205a545ee62e0f0f797c1e2b0bd2062d96414b3
> Author: Andre Noll <maan@...go.fml.local>
> Date:   Wed Mar 19 11:39:55 2008 +0100
> 
> From: Andre Noll <maan@...temlinux.org>
> 
> commit e9720ac ([NET]: Make /proc/net a symlink on /proc/self/net (v3))
> broke ganglia and probably other applications that read /proc/net/dev.

This also broke the postfix, as it was reported in bug #10286
and described in detail by Benjamin.

> This is due to the change of permissions of /proc/net that was
> introduced in that commit.
> 
> Before: dr-xr-xr-x 5 root root 0 Mar 19 11:30 /proc/net
> After: dr-xr--r-- 5 root root 0 Mar 19 11:29 /proc/self/net
> 
> This patch restores the permissions to the old value which makes ganglia
> happy again.

And it fixes the problem reported by Benjamin.
Thanks, Andre!

> Signed-off-by: Andre Noll <maan@...temlinux.org>

Acked-by: Pavel Emelyanov <xemul@...nvz.org>
 
> diff --git a/fs/proc/base.c b/fs/proc/base.c
> index 8a10f6f..81d7d14 100644
> --- a/fs/proc/base.c
> +++ b/fs/proc/base.c
> @@ -2290,7 +2290,7 @@ static const struct pid_entry tgid_base_stuff[] = {
>  	DIR("fd",         S_IRUSR|S_IXUSR, fd),
>  	DIR("fdinfo",     S_IRUSR|S_IXUSR, fdinfo),
>  #ifdef CONFIG_NET
> -	DIR("net",        S_IRUGO|S_IXUSR, net),
> +	DIR("net",        S_IRUGO|S_IXUGO, net),
>  #endif
>  	REG("environ",    S_IRUSR, environ),
>  	INF("auxv",       S_IRUSR, pid_auxv),

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/