lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Thu, 20 Mar 2008 12:06:40 +0100
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	"Artem S. Tashkinov" <birdie@...monline.ru>
CC:	Jan Engelhardt <jengelh@...putergmbh.de>,
	linux-kernel@...r.kernel.org
Subject: Re: GIT commit description flag(s)

Artem S. Tashkinov wrote:
> I quite agree with you that the description is already there, but such 
> flags could help easily review or grep commits in order to identify your 
> areas of interest.
> 
> Even your example has ambiguity: "Wire up new timerfd syscalls" - It's 
> not easy to understand whether this particular commit is a bugfix, or it 
> speeds up things, or the old code which has been cleaned up, etc.

The fundamental problems
  - people sometimes chose bad summaries,
  - we can't always predict the full impact of the patch,
  - what's important for me isn't for you
cannot be solved by your proposed flags.

They can only be solved by
  - reviewing patches WRT good changelogs,
  - writing up extra summary release notes for areas of interest
    after the fact.

>>> It would be nice if [kernel] git commits had a flag [a char] (or a
>>> combination of) describing their main purpose which could be the
>>> following:
>>>
>>> bug Fix [F]
>>> Speed up/Performance [S]
>>> Revert [R]
>>> New functionality [N]

New bug [B]
Attempted bug fix which doesn't really work, a.k.a. nice Try [T]
Performance regression, a.k.a Downgrade [D]
-- 
Stefan Richter
-=====-==--- --== =-=--
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ