lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 19 Mar 2008 16:50:28 -0700
From:	"Yu, Fenghua" <fenghua.yu@...el.com>
To:	"Peter Zijlstra" <a.p.zijlstra@...llo.nl>
Cc:	"KOSAKI Motohiro" <kosaki.motohiro@...fujitsu.com>,
	"Luck, Tony" <tony.luck@...el.com>,
	"LKML" <linux-kernel@...r.kernel.org>,
	<linux-ia64@...r.kernel.org>,
	"Hidetoshi Seto" <seto.hidetoshi@...fujitsu.com>,
	"Andrew Morton" <akpm@...ux-foundation.org>
Subject: RE: [2.6.25-rc5-mm1][regression] ia64: hackbench doesn't finish>12 hour


>Which makes me wonder, why did you ever use a semaphore here? Looking
at
>the code its a straight forward mutex. And when you would have used a
>mutex lockdep would have warned about this.

>There is hardly ever a good reason to use semaphores in new code, we're
>trying very hard to get rid of them.

The real issue here is the code path can not go to sleep. If simply 
replacing semaphore with mutex, the issue still happens. First of all we

need to have a lock system which doesn't allow the code go to sleep. We
are 
working on a new patch now.

But one step back, if without considering this sleeping issue, I agree
with 
you that mutex would be a better approach than semaphore.

>Hmm, then again, does ia64 have lockdep?

IA64 doesn't support lockdep yet.

Thanks.

-Fenghua
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists