linux-kernel - Re: [PATCH v3] x86: merge the simple bitops and move them to bitops.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 21 Mar 2008 13:35:48 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Alexander van Heukelum <heukelum@...lshack.com>
Cc:	Randy Dunlap <randy.dunlap@...cle.com>,
	Jeremy Fitzhardinge <jeremy@...p.org>,
	Alexander van Heukelum <heukelum@...tmail.fm>,
	Andi Kleen <andi@...stfloor.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] x86: merge the simple bitops and move them to
	bitops.h


* Alexander van Heukelum <heukelum@...lshack.com> wrote:

> x86: merge the simple bitops and move them to bitops.h.
> 
> Some of those can be written in such a way that the same inline 
> assembly can be used to generate both 32 bit and 64 bit code.
> 
> For ffs and fls, x86_64 unconditionally used the cmov instruction and 
> i386 unconditionally used a conditional branch over a mov instruction. 
> In the current patch I chose to select the version based on the 
> availability of the cmov instruction instead. A small detail here is 
> that x86_64 did not previously set CONFIG_X86_CMOV=y.
> 
> Improved comments for ffs, ffz, fls and variations.

thanks Alexander, applied.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/