linux-kernel - Re: [PATCH] bttv: Add a radio compat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 22 Mar 2008 20:17:40 +0200
From:	Bongani Hlope <bonganilinux@...b.co.za>
To:	Robert Fitzsimons <robfitz@...k.net>
Cc:	Mauro Carvalho Chehab <mchehab@...radead.org>,
	video4linux-list@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bttv: Add a radio compat_ioctl file operation.

On Saturday 22 March 2008 02:05:57 Robert Fitzsimons wrote:
> Signed-off-by: Robert Fitzsimons <robfitz@...k.net>
> ---
>  drivers/media/video/bt8xx/bttv-driver.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
>
> Hi Bongani
>
> I only noticed that you might be using a 32 bit userspace, so the radio
> compat_ioctl needs to be implmented.
>
> Robert
>
>
>
> diff --git a/drivers/media/video/bt8xx/bttv-driver.c
> b/drivers/media/video/bt8xx/bttv-driver.c index 5404fcc..1bdb726 100644
> --- a/drivers/media/video/bt8xx/bttv-driver.c
> +++ b/drivers/media/video/bt8xx/bttv-driver.c
> @@ -3601,6 +3601,7 @@ static const struct file_operations radio_fops =
>  	.read     = radio_read,
>  	.release  = radio_release,
>  	.ioctl	  = video_ioctl2,
> +	.compat_ioctl	= v4l_compat_ioctl32,
>  	.llseek	  = no_llseek,
>  	.poll     = radio_poll,
>  };

I run a 64-bit kernel and 64-bit user-space, only a chrooted version of 
mplayer and it's dependencies are 32 bit, and I don't use them that often.

file /usr/bin/radio
/usr/bin/radio: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), for 
GNU/Linux 2.6.9, dynamically linked (uses shared libs), stripped

That patch doesn't help also...


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/